fix FacDB FACTYPE bugs#2360
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
damonmcc
force-pushed
the
dm-facdb-bugs
branch
11 times, most recently
from
82ea154 to
419d6b0
Compare
damonmcc
commented
May 12, 2026
Member
Author
There was a problem hiding this comment.
new tests here. the null FACNAME test isn't related to this PR but want to revisit it later for general data quality improvements
we'd rather be able to be explicit in case statements
alexrichey
approved these changes
May 12, 2026
Contributor
alexrichey
left a comment
alexrichey
left a comment
There was a problem hiding this comment.
Love it, esp the dbt'ization. I do think at some point we need to rip the cleaning logic out of facdb and into ingest, which would perhaps enable us to track changes to those datasets a little more cleanly. But that's a whole endeavor of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2359
all builds on this branch
changes
s3_comparemarimo notebook used to compare build filesFACTYPEvaluesFACTYPEandFACSUBGRPFACTYPEvaluesFACTYPEandFACSUBGRPto avoid many-to-many relationshipsfollow up work
as part of QA for the next FacDB release these mapping improvements and changes will be reviewed more thoroughly than usual. since this PR is about fixing nulls and relationships for AE's dev work, the actual mappings aren't as important as tests passing
validation/tests
new build tests passing here
comparing main and dev builds using the
s3_comparemarimo notebooksame source data
different counts of records when grouped by
FACSUBGRPaccording to theqc_classification.csvoutputfor example, there are now 15 more
IMMIGRANT SERVICESrecords